1. 22 Aug, 2022 1 commit
  2. 12 Aug, 2022 1 commit
  3. 08 Aug, 2022 1 commit
  4. 13 Jul, 2022 1 commit
  5. 08 Jul, 2022 1 commit
    • Eloy Lafuente's avatar
      MDL-71747 upgrade: remove all the < 3.9.0 upgrade steps · 58b56e23
      Eloy Lafuente authored
      This just deletes all the upgrade steps previous to 3.9.0. Some
      small adjustments, like tweaking globals can also be applied
      when needed.
      
      Also includes an upgrade step to prevent upgrading from any
      version < 2020061500 (v3.9.0) as anti-cheating measure.
      
      The next commits will proceed to deprecate / remove functions
      that were exclusively (usually belonging to upgradelib) being
      used by those, now removed, upgrade steps. This is the list
      of code to remove and document in upgrade.txt files:
      
        - upgrade_analytics_fix_contextids_defaults()
        - upgrade_convert_hub_config_site_param_names()
        - upgrade_rename_prediction_actions_useful_incorrectly_flagged()
        - \mod_forum\task\refresh_forum_post_counts adhoc task.
      
      And these is the code that has NOT been removed
      because it may be needed later (no matter there aren't uses now):
      
        - \core_search\manager::clean_up_non_existing_area(), used by
        - \core\task\clean_up_deleted_search_area_task adhoc task
      58b56e23
  6. 29 Jun, 2022 1 commit
  7. 22 Jun, 2022 1 commit
  8. 15 Jun, 2022 1 commit
  9. 16 May, 2022 1 commit
  10. 08 May, 2022 1 commit
    • Eloy Lafuente's avatar
      MDL-74413 phpunit: Move more tests to use correct names and namespaces · caf55abf
      Eloy Lafuente authored
      Applied the following changes to various testcase classes:
      
      - Namespaced with component[\level2-API]
      - Moved to level2-API subdirectory when required.
      - Fixed incorrect use statements with leading backslash.
      - Remove file phpdoc block
      - Remove MOODLE_INTERNAL if not needed.
      - Changed code to point to global scope when needed.
      - Fix some relative paths and comments here and there.
      - All them passing individually.
      - Complete runs passing too.
      
      Special mention to:
      
      - Moved to the level2 "privacy" namespace:
        - \mod_assign\privacy\feedback_legacy_polyfill_test
        - \mod_assign\privacy\submission_legacy_polyfill_test
      
      - Moved to the level2 "task" namespace:
        - \core_message\task\migrate_message_data_test
        - \ltiservice_gradebookservices\task\cleanup_test
        - \message_email\task\send_email_test
        - \mod_lti\task\clean_access_tokens_test
        - \mod_workshop\task\cron_task_test
      
      - Moved to the level2 "event" namespace:
        - \core_h5p\event\dele...
      caf55abf
  11. 23 Apr, 2022 1 commit
  12. 13 Apr, 2022 1 commit
  13. 07 Apr, 2022 1 commit
  14. 21 Mar, 2022 1 commit
  15. 24 Feb, 2022 1 commit
    • Sara Arjona's avatar
      MDL-73917 message: Remove labels from notification preferences · d4ebb398
      Sara Arjona authored
      In MDL-67853, the "Enabled" label was added to all the toggle switches in the
      user notification preferences page. This string is confusing, so this issue
      is to remove it (and leave it as it was in 3.11).
      
      Apart from that, following Helen's suggestion, I've renamed "Disallowed" to
      "Locked off" and "Locked" to "Locked on", in order to help users to understand
      better their meaning.
      d4ebb398
  16. 23 Feb, 2022 3 commits
    • Andrew Nicols's avatar
      MDL-73915 js: Drop support for IE and android · e1b9d5f3
      Andrew Nicols authored
      Moodle announced that support for IE would be dropped back in August
      2020 with Moodle 3.9 but not active steps were taken at that time. That
      decision was made in MDLSITE-6109 and this particular step was meant to
      be taken in Moodle 3.10.
      
      This is the first step taken to actively drop support for IE.
      
      This commit also bumps the browser support pattern from 0.25% to 0.3%.
      The percentage here includes any browser where at least this percentage
      of users worldwide may be using a browser. In this case it causes
      support for Android 4.3-4.4 to be dropped, which relate to Android
      KitKat (released 2013).
      
      This combination of changes means that all of the supported browsers in
      our compatibility list support modern features including async,
      for...of, classes, native Promises, and more which has a huge impact on
      the ease of debugging code, and drastically reduces the minified file
      size because a number of native Polyfills included by Babel are no
      longer included.
      e1b9d5f3
    • Andrew Nicols's avatar
      MDL-73915 js: Switch amd minification to terser · 0a4047ab
      Andrew Nicols authored
      Unfortunately the babel minify-mangle plugin seems to be abandoned and
      in certain circumstances can be very buggy. The only safe options are to
      disable it, or to switch to a different minification library.
      
      Not minifying our javascript is not ideal, so this commit updates the
      javascript tasks to use a rollup, combined with babel, and terser.
      
      Babel still converts code from ES/UMD/AMD to AMD modules with the
      relevant browser support, whilst terser minifies the code.
      
      The rollup bundler handles tracking and creation of sourcemaps, and
      supports better parallelisation of the tasks.
      
      Since the upgrade to Node LTS/Gallium requires an upgrade to @babel/core
      and eslint, which change the built files anyway, this seems like the
      ideal time to make this change.
      0a4047ab
    • Andrew Nicols's avatar
      MDL-73915 js: Upgrade babel and eslint · aa7f7957
      Andrew Nicols authored
      aa7f7957
  17. 16 Feb, 2022 1 commit
  18. 09 Feb, 2022 1 commit
    • Eloy Lafuente's avatar
      MDL-73764 tool_xmldb: Regenerate all the files detected by the report · 3bb4a400
      Eloy Lafuente authored
      Note that, instead of going one by one to them from the XMLDB Editor
      (load, makes some tiny change, save, revert the change, save), the
      report includes a commented line that, once uncommented, does regenerate
      the file while reporting.
      
      I've left it there as a commodity for the developer.
      3bb4a400
  19. 05 Feb, 2022 1 commit
    • Eloy Lafuente's avatar
      MDL-73659 phpunit: restore_date, api, rule, plugin, manager & helper · 7a0d024e
      Eloy Lafuente authored
      All restore_date_test, api_test, rule_test, plugin_test,
      manager_test, helper_test testcase classes:
      
      - Namespaced with component[\level2-API]
      - Moved to level2-API subdirectory when required.
      - Fixed incorrect use statements with leading backslash.
      - Remove file phpdoc block
      - Remove MOODLE_INTERNAL if not needed.
      - Changed code to point to global scope when needed.
      - Fix some relative paths and comments here and there.
      - All them passing individually.
      - Complete runs passing too.
      
      Special mention to:
      
      - All restore_date_test cases have been put under xxx\backup
        level 2 (valid API) namespace.
      7a0d024e
  20. 27 Jan, 2022 2 commits
  21. 22 Jan, 2022 1 commit
    • Eloy Lafuente's avatar
      MDL-73485 phpunit: externallib, generator and filter tescase names · 100bc51f
      Eloy Lafuente authored
      All externallib_test, generator_test and filter_test classes:
      
      - Namespaced with component[\level2-API]
      - Moved to level2-API subdirectory when required.
      - Fixed incorrect use statements with leading backslash.
      - Changed code to point to global scope when needed.
      - Fix some relative paths and comments here and there.
      - All them passing individually.
      - Complete runs passing too.
      
      Special mention to tests under testing/tests:
      
      1) The core_testing component doesn't exist.
      2) But testing/tests are allowed because there is a suite pointing to it (phpunit.xml).
      3) So, the only possible namespace for them is "core".
      4) And to avoid problems with other core testcases (under lib/tests)
         they have been renamed to have testing_xxxx as prefix.
      
      Finally, also modified calendar/tests/events/events_test.php because it uses
      some renamed (core_calendar_externallib_testcase => \core_calendar\externallib_test)
      classes.
      100bc51f
  22. 14 Jan, 2022 1 commit
    • Eloy Lafuente's avatar
      MDL-73476 phpunit: events, external and search tescase names · 0c53a3de
      Eloy Lafuente authored
      All events_test, external_test and search_test classes:
      
      - Namespaced with component[\level2-API]
      - Moved to level2-API subdirectory when required.
      - Fixed incorrect use statements with leading backslash.
      - Changed code to point to global scope when needed.
      - Fix some relative paths and comments here and there.
      - All them passing individually.
      - Complete runs passing too.
      
      Special mention to lib/external/tests/external_test.php:
      - external is not a valid component
      - hence, its only valid namespace is "core"
      - also, it's testing lib/external/externallib.php
      - hence, the file (and class) have been renamed to external_externallib_test.php
        (to avoid conflicts with other external_test that may exist in core)
      0c53a3de
  23. 17 Dec, 2021 2 commits
    • Eloy Lafuente's avatar
      MDL-73348 phpunit: normalize all privacy provider tests · e4a2d9c1
      Eloy Lafuente authored
      As far as now all them have correct privacy level2 namespace:
      - Move them to "privacy" subdir.
      - Rename the files to "provider_test.php", this includes old
        privacy_test.php and privacy_provider_test.php files
      - Rename the testcase to provider_test too (to match file name)
      
      Also, change some relative paths and comments to point to new
      locations.
      e4a2d9c1
    • Eloy Lafuente's avatar
      MDL-73348 phpunit: privacy and privacy_provider testcase names · 57e6fb7a
      Eloy Lafuente authored
      All privacy_test and privacy_provider_test classes:
      
      - Namespaced with component\privacy.
      - Fixed incorrect use statements with leading backslash.
      - Changed code to point to global scope when needed.
      - Renamed a few files to make all be privacy_test or privacy_provider_test.php
      - All them passing individually.
      - Complete runs passing too.
      57e6fb7a
  24. 09 Dec, 2021 1 commit
  25. 16 Nov, 2021 1 commit
  26. 05 Nov, 2021 1 commit
  27. 04 Nov, 2021 1 commit
  28. 28 Oct, 2021 1 commit
    • Neill Magill's avatar
      MDL-63983 messaging: Improve the performance of non-contact searches · a8d9b17b
      Neill Magill authored
      When the messagingallusers setting is disabled only contacts that are
      on the same course as the user should be returned as results.
      
      We can reduce the number of candidate users significantly by
      pre-filtering them by being enrolled on the same courses as the user
      performing the search.
      
      Since we must also return the user themselves sometimes, even when they
      are not enrolled on a course I used a UNION as the most efficient way of
      retriving them, this meant that the order by had to reference returned
      columns by number to be sufficiently cross-database compatiable.
      a8d9b17b
  29. 21 Oct, 2021 1 commit
  30. 15 Oct, 2021 1 commit
  31. 04 Oct, 2021 1 commit
  32. 30 Sep, 2021 2 commits
  33. 28 Sep, 2021 1 commit
  34. 13 Sep, 2021 1 commit
  35. 31 Aug, 2021 1 commit