* Unit tests for completion_info::get_data() and
completion_info::internal_get_state are mocked which causes failures
with the new implementation. It's more straightforward and realistic
to generate real course and modules to test these methods.

Tests cover
 - get_overall_completion_state()
 - is_available()
 - validate_rule()
Tests don't cover
 - methods that rely on static methods such as:
   - is_defined()
 - static methods in the class because they can't be mocked
 - abstract methods that can be tested better by the plugins
   that extend activity_custom_completion such as:
   - get_state()
   - get_defined_custom_rules()
   - get_custom_rule_descriptions()

* Base class for defining an activity module's custom completion details

Paul Holden authored Mar 03, 2021 and jun committed Mar 03, 2021

Teachers can see user idnumber fields only when they are configured
identity fields. Students cannot.

Paul Holden authored Mar 01, 2021 and jun committed Mar 03, 2021

This commit also corrects parameter definition of the field to
match core_user.

When retrieving courses of another user via web services, we should
respect the capability to view that users profile in a given course.

Co-authored-by: Michael Hawkins <michaelh@moodle.com>

Fixed mod/workshop/db/upgrade.php: \xmldb_field::getNotNull()
does not verify if the column is nullable in the database.