Also fixed unit test filter.

The login domains were checking the email of the moodle account, not the returned
email from oauth. Also after a failure, it was not killing the oauth session, which
prevents you trying again with a different account.

The username passed to the confirm account link request is the oauth username,
which may be different to the moodle username so can't be used to look up the user record.

The event test factory uses a closure to return only every other record.
This was previously working based on ID but MSSQL starts from an even
number rather than an odd number.

This change changes that to use a static variable which keeps a count of
the records instead and only returns every other record in this fashion,
removing the dependance upon ID.

This was broken by the refactoring to always link logins. Some of the static
variables could also be removed but I'll do that in a later issue to keep this patch small.

We should indicate the API changes for developers.

Simey Lameze authored Apr 04, 2017 and Dan Poltawski committed Apr 04, 2017

Part of MDL-55611 epic.