1. 31 Mar, 2021 1 commit
  2. 12 Mar, 2021 1 commit
  3. 14 Jan, 2021 1 commit
    • Eloy Lafuente's avatar
      MDL-69308 upgrade: remove all the < 3.6.0 upgrade steps · 77342b96
      Eloy Lafuente authored
      This just deletes all the upgrade steps previous to 3.6.0. Some
      small adjustments, like tweaking globals can also be applied
      when needed.
      
      Also includes an upgrade step to prevent upgrading from any
      version < 2018120300 (v3.6.0) as anti-cheating measure.
      
      Note that in this case, there wasn't any case of upgradelib
      functions being used, hence we haven't to deprecate/remove
      anything in codebase. When there is such a need, that is done
      in separate commits (one for each function) and documented here.
      
      See MDL-65809 commits for an example removing/deprecating a
      good number of functions.
      77342b96
  4. 18 Dec, 2020 2 commits
  5. 11 Nov, 2020 1 commit
  6. 29 Oct, 2020 2 commits
    • jun's avatar
      MDL-70032 qtype_multichoice: Use custom partial named selector · ac9ecf6b
      jun authored
      * With the removal of the label element, Behat now has to click on the
      answer text. In order to achieve this, the custom partial named selector
      "qtype_multichoice > Answer" was now added and have replaced the
      instances where the label of the answer's checkbox/radio button is
      being clicked.
      ac9ecf6b
    • jun's avatar
      MDL-70032 qtype_multichoice: Fix answer labelling · a1d81dc6
      jun authored
      * Discard the use of the label element in order to be able to render
      multiple choice answers as they are and have these act as the radio
      button/checkbox' label through the aria-labelledby attribute.
      * New JS module qtype_multichoice/answers that listens for click events
      on the answer text container and selects the appropriate answer radio
      button/checkbox.
      a1d81dc6
  7. 27 Oct, 2020 1 commit
  8. 21 Oct, 2020 3 commits
    • Eloy Lafuente's avatar
      MDL-67673 phpunit: Remove deprecated assertEquals() params · 3a5641cb
      Eloy Lafuente authored
      The optional parameters of assertEquals() and assertNotEquals()
      are deprecated in PHPUnit 8 (to be removed in PHPUnit 9):
      
      - delta => use assertEqualsWithDelta()
      - canonicalize => use assertEqualsCanonicalizing()
      - ignoreCase => use assertEqualsIgnoringCase
      - maxDepth => removed without replacement.
      
      More info @ https://github.com/sebastianbergmann/phpunit/issues/3341
      
      Initial search done with:
      
      ag 'assert(Not)?Equals\(.*,.*,' --php
      
      Then, running tests and fixing remaining cases.
      3a5641cb
    • Eloy Lafuente's avatar
      MDL-67673 phpunit: Remove deprecated non-public attribute assertions · a293b3ae
      Eloy Lafuente authored
      With PHPUnit 8 a good number of assertions, all them related with
      operations on non-public attributes have been deprecated. And will
      be removed with PHPUnit 9.
      
      The main point is that unit tests shouldn't be testing non-public
      APIs (good practice) and those assertions were an error originally.
      
      See https://github.com/sebastianbergmann/phpunit/issues/3338 for
      the complete list and other details.
      
      When possible (the attributes being checked are public), the change
      is simple, just switching to normal assertions.
      
      When the attributes are not public we need to find a workaround
      to be able to test the same using public APIs, or use Reflection,
      or remove the tests.
      
      For the records, this is the regexp used to find all the cases:
      
      ag '>(assertAttribute|attribute\(|readAttributte|getStaticAttribute| \
          getObjectAttribute)' -G "test.php"
      a293b3ae
    • Eloy Lafuente's avatar
      MDL-67673 phpunit: Fix the return type of template methods · f6711bb3
      Eloy Lafuente authored
      All the setup/teardown/pre/post/conditions template methods
      now are required to return void. This was warned with phpunit 7
      and now is enforced.
      
      At the same time, fix a few wrong function names,
      provider data and param types, return statements...
      f6711bb3
  9. 31 Aug, 2020 2 commits
  10. 18 Aug, 2020 1 commit
    • Eloy Lafuente's avatar
      MDL-69475 versions: bump all versions and requires in master · fbb07675
      Eloy Lafuente authored
      version = 2021052500 release version
      requires= 2021052500 same than version
      
      Why 20210525? (25th May 2021) ?
      
      Because master is going to be Moodle 4.0, to be released
      on November 2021. And, until then, we are going to have
      a couple of "intermediate" releases:
      
      - Moodle 3.10 to be released 9th November 2020. (2020110900)
      
        This version will be using versions from today to 2020110900
        (once it's released the YYYYMMDD part stops advancing).
      
      - Moodle 3.11 to be released 10th May 2021. (2021051000)
      
        This version will be using versions from 3.10 release to 2021051000
        (once it's released the YYYYMMDD part stops advancing).
      
      That means that all versions from today to 2021051000 are going
      to be used by those 2 "intermediate" releases (3.10 and 3.11).
      
      And we cannot use them in master, because it's forbidden to have
      any overlapping of versions between branches (or different upgrade
      paths will fail).
      
      So, get that 2021051000, let's add it a couple of weeks to cover
      the on-sync period (or a 2 weeks delay max!) and, the first version
      that master can "own" in exclusive (without any overlap) is, exactly,
      25th May 2021, hence our 20210525.
      fbb07675
  11. 17 Aug, 2020 1 commit
    • Eloy Lafuente's avatar
      MDL-69475 versions: bump all versions and requires in master · 45ce46f2
      Eloy Lafuente authored
      version = 2021052500 release version
      requires= 2021052500 same than version
      
      Why 20210525? (25th May 2021) ?
      
      Because master is going to be Moodle 4.0, to be released
      on November 2021. And, until then, we are going to have
      a couple of "intermediate" releases:
      
      - Moodle 3.10 to be released 9th November 2020. (2020110900)
      
        This version will be using versions from today to 2020110900
        (once it's released the YYYYMMDD part stops advancing).
      
      - Moodle 3.11 to be released 10th May 2021. (2021051000)
      
        This version will be using versions from 3.10 release to 2021051000
        (once it's released the YYYYMMDD part stops advancing).
      
      That means that all versions from today to 2021051000 are going
      to be used by those 2 "intermediate" releases (3.10 and 3.11).
      
      And we cannot use them in mater, because it's forbidden to have
      any overlapping of versions between branches (or different upgrade
      paths will fail).
      
      So, get that 2021051000, let's add it a couple of weeks to cover
      the on-sync period (or a 2 weeks delay max!) and, the first version
      that master can "own" in exclusive (without any overlap) is, exactly,
      25th May 2021, hence our 20210525.
      45ce46f2
  12. 15 Jul, 2020 1 commit
  13. 14 Jun, 2020 1 commit
  14. 10 Jun, 2020 4 commits
  15. 09 Jun, 2020 1 commit
  16. 08 Jun, 2020 1 commit
  17. 03 Jun, 2020 1 commit
  18. 27 May, 2020 1 commit
  19. 22 May, 2020 1 commit
  20. 21 May, 2020 1 commit
  21. 27 Feb, 2020 1 commit
    • bas's avatar
      MDL-67901 type_multichoice: clear my choice accessibility · e06b302e
      bas authored
      Improve the accessibility for the clear my choice option. The
      extra radio input controlling the reset feature was removed and
      resetting the choice is now controlled by JavaScript.
      This fixes the missing label reported in Accessibility audit and W3C
      validation of the reset link
      
      By this change this issue also fixes MDL-67280
      e06b302e
  22. 20 Dec, 2019 1 commit
    • Sara Arjona's avatar
      MDL-65809 upgrade: clean < 3.5.0 upgrade steps · a26cfe71
      Sara Arjona authored
      This just deletes all the upgrade steps previous to 3.5.0. Some
      small adjustments, like tweaking globals can also be applied
      when needed.
      
      Also includes an upgrade step to prevent upgrading from any
      version < 2018051700 (v3.5.0) as anti-cheating measure.
      
      Previous commits have removed/deprecated all the upgradelib functions
      not used anymore in codebase. Deletion has been documented in corresponding
      upgrade.txt files:
      
      - upgrade_fix_block_instance_configuration()
      - upgrade_theme_is_from_family(), upgrade_find_theme_location()
      and linkcoursesectionsupgradescriptwasrun setting
      - upgrade_block_positions
      - upgrade_fix_config_auth_plugin_names()
       and upgrade_fix_config_auth_plugin_defaults()
      - format_xxx_upgrade_remove_numsections(), format_xxx_upgrade_hide_extra_sections()
      and format_xxx_upgrade_add_empty_sections()
      - filter_mathjaxloader_upgrade_cdn_cloudflare()
      and filter_mathjaxloader_upgrade_mathjaxconfig_equal()
      - get_assignments_with_rescaled_null_grades()
      
      ...
      a26cfe71
  23. 17 Nov, 2019 1 commit
  24. 13 Nov, 2019 1 commit
  25. 14 Oct, 2019 1 commit
    • Tim Hunt's avatar
      MDL-66821 question behat: new step for acting on questions in the bank · 9c14b28d
      Tim Hunt authored
      There is a proposed change MDL-66816 which will change the question
      bank UI. This will break any Behat tests which uses low-level steps
      like
      
          When I click on "Duplicate" "link" in the "Test question" "table_row"
      
      to perform an action on a question in the question bank. This commit
      introduces a new step:
      
          When I choose "Duplicate" action for "Test question" in the question bank
      
      This commit also converts all core Behat tests to use the new step.
      9c14b28d
  26. 19 Jul, 2019 1 commit
  27. 21 May, 2019 1 commit
  28. 13 May, 2019 1 commit
  29. 10 May, 2019 1 commit
  30. 01 May, 2019 1 commit
  31. 29 Apr, 2019 2 commits