Commit b1955237 authored by Tim Hunt's avatar Tim Hunt Committed by Shamim Rezaie
Browse files

MDL-63809 question bank: ensure question_has_capability_on can be called

parent 33a388ef
......@@ -52,8 +52,4 @@ class add_action_column extends \core_question\bank\action_column_base {
}
$this->print_icon('t/add', $this->stradd, $this->qbank->add_to_quiz_url($question->id));
}
public function get_required_fields() {
return array('q.id');
}
}
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Unit tests for the quiz's own question bank view class.
*
* @package mod_quiz
* @category test
* @copyright 2018 the Open University
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
defined('MOODLE_INTERNAL') || die();
global $CFG;
require_once($CFG->dirroot . '/question/editlib.php');
/**
* Unit tests for the quiz's own question bank view class.
*
* @copyright 2018 the Open University
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class quiz_question_bank_view_testcase extends advanced_testcase {
public function test_viewing_question_bank_should_not_load_individual_questions() {
$this->resetAfterTest();
$this->setAdminUser();
$generator = $this->getDataGenerator();
/** @var core_question_generator $questiongenerator */
$questiongenerator = $generator->get_plugin_generator('core_question');
// Create a course and a quiz.
$course = $generator->create_course();
$quiz = $this->getDataGenerator()->create_module('quiz', array('course' => $course->id));
$context = context_module::instance($quiz->cmid);
$cm = get_coursemodule_from_instance('quiz', $quiz->id);
// Create a question in the default category.
$contexts = new question_edit_contexts($context);
$cat = question_make_default_categories($contexts->all());
$questiondata = $questiongenerator->create_question('numerical', null,
['name' => 'Example question', 'category' => $cat->id]);
// Ensure the question is not in the cache.
$cache = cache::make('core', 'questiondata');
$cache->delete($questiondata->id);
// Generate the view.
$view = new mod_quiz\question\bank\custom_view($contexts, new moodle_url('/'), $course, $cm, $quiz);
ob_start();
$view->display('editq', 0, 20, $cat->id . ',' . $cat->contextid, false, false, false);
$html = ob_get_clean();
// Verify the output includes the expected question.
$this->assertContains('Example question', $html);
// Verify the question has not been loaded into the cache.
$this->assertFalse($cache->has($questiondata->id));
}
}
......@@ -51,6 +51,8 @@ class delete_action_column extends action_column_base {
}
public function get_required_fields() {
return array('q.id', 'q.hidden');
$required = parent::get_required_fields();
$required[] = 'q.hidden';
return $required;
}
}
......@@ -34,8 +34,4 @@ class preview_action_column extends action_column_base {
$question->id, $this->qbank->get_most_specific_context(), false);
}
}
public function get_required_fields() {
return array('q.id');
}
}
......@@ -44,7 +44,7 @@ class core_question_bank_view_testcase extends advanced_testcase {
/** @var core_question_generator $questiongenerator */
$questiongenerator = $generator->get_plugin_generator('core_question');
// Cerate a course.
// Create a course.
$course = $generator->create_course();
$context = context_course::instance($course->id);
......@@ -54,7 +54,7 @@ class core_question_bank_view_testcase extends advanced_testcase {
$questiondata = $questiongenerator->create_question('numerical', null,
['name' => 'Example question', 'category' => $cat->id]);
// Ensure the qusetion is not in the cache.
// Ensure the question is not in the cache.
$cache = cache::make('core', 'questiondata');
$cache->delete($questiondata->id);
......@@ -67,7 +67,7 @@ class core_question_bank_view_testcase extends advanced_testcase {
// Verify the output includes the expected question.
$this->assertContains('Example question', $html);
// Verify the qusetion has not been loaded into the cache.
// Verify the question has not been loaded into the cache.
$this->assertFalse($cache->has($questiondata->id));
}
}
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment