Commit 6d721cab authored by Mark Nelson's avatar Mark Nelson
Browse files

MDL-59362 core: ensure we use 'new' when throwing exceptions

parent f4a2d696
......@@ -146,7 +146,7 @@ class core_plugin_manager {
public function get_plugin_types() {
if (func_num_args() > 0) {
if (!func_get_arg(0)) {
throw coding_exception('core_plugin_manager->get_plugin_types() does not support relative paths.');
throw new coding_exception('core_plugin_manager->get_plugin_types() does not support relative paths.');
}
}
if ($this->plugintypes) {
......
......@@ -3651,7 +3651,7 @@ class breadcrumb_navigation_node extends navigation_node {
$this->$key = $value;
}
} else {
throw coding_exception('Not a valid breadcrumb_navigation_node');
throw new coding_exception('Not a valid breadcrumb_navigation_node');
}
}
......@@ -3705,7 +3705,7 @@ class flat_navigation_node extends navigation_node {
$this->$key = $value;
}
} else {
throw coding_exception('Not a valid flat_navigation_node');
throw new coding_exception('Not a valid flat_navigation_node');
}
$this->indent = $indent;
}
......
......@@ -303,7 +303,7 @@ class core_tag_collection {
public static function change_sortorder($tagcoll, $direction) {
global $DB;
if ($direction != -1 && $direction != 1) {
throw coding_exception('Second argument in tag_coll_change_sortorder() can be only 1 or -1');
throw new coding_exception('Second argument in tag_coll_change_sortorder() can be only 1 or -1');
}
$tagcolls = self::get_collections();
$keys = array_keys($tagcolls);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment