Commit 5a6084cf authored by Andrew Robert Nicols's avatar Andrew Robert Nicols
Browse files

MDL-29818: Improve error message when a grade has no answer

parent 6731a04d
......@@ -109,9 +109,13 @@ class qtype_multichoice_edit_form extends question_edit_form {
foreach ($answers as $key => $answer) {
//check no of choices
$trimmedanswer = trim($answer['text']);
if (empty($trimmedanswer)) {
$fraction = (float) $data['fraction'][$key];
if (empty($trimmedanswer) && empty($fraction)) {
continue;
}
if (empty($trimmedanswer)) {
$errors['fraction['.$key.']'] = get_string('errgradesetanswerblank', 'qtype_multichoice');
}
$answercount++;
......
......@@ -41,6 +41,7 @@ $string['clozeaid'] = 'Enter missing word';
$string['correctansweris'] = 'The correct answer is: {$a}.';
$string['correctfeedback'] = 'For any correct response';
$string['editingmultichoice'] = 'Editing a Multiple choice question';
$string['errgradesetanswerblank'] = 'Grade set, but the Answer is blank';
$string['errfractionsaddwrong'] = 'The positive grades you have chosen do not add up to 100%<br />Instead, they add up to {$a}%';
$string['errfractionsnomax'] = 'One of the choices should be 100%, so that it is<br />possible to get a full grade for this question.';
$string['feedback'] = 'Feedback';
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment