quiz MDL-10128 popup checker no longer requests a non-existent file which was...

quiz MDL-10128 popup checker no longer requests a non-existent file which was causing messages in server logs

lib/javascript-static.js

 // Miscellaneous core Javascript functions for Moodle
 
 function popupchecker(msg) {
-    var testwindow = window.open('itestwin.html', '', 'width=1,height=1,left=0,top=0,scrollbars=no');
+    var testwindow = window.open('', '', 'width=1,height=1,left=0,top=0,scrollbars=no');
     if (!testwindow) {
         alert(msg);
     } else {

mod/quiz/view.php

@@ -63,10 +63,8 @@
         $USER->editing = $edit;
     }
 
-/// Print the page header
-    $bodytags = '';
     if ($accessmanager->securewindow_required($canpreview)) {
-        $bodytags = 'onload="popupchecker(\'' . get_string('popupblockerwarning', 'quiz') . '\');"';
+        $PAGE->requires->js_function_call('popupchecker',array(get_string('popupblockerwarning', 'quiz')));
     }
     $PAGE->requires->yui_lib('event');