MDL-47494 gapselect: Add lots of missing public/protected/private.

question/type/gapselect/backup/moodle2/restore_qtype_gapselect_plugin.class.php

@@ -124,7 +124,7 @@ class restore_qtype_gapselect_plugin extends restore_qtype_plugin {
     /**
      * Return the contents of this qtype to be processed by the links decoder
      */
-    static public function define_decode_contents() {
+    public static function define_decode_contents() {
 
         $contents = array();
 

question/type/gapselect/edit_form_base.php

@@ -92,7 +92,7 @@ class qtype_gapselect_edit_form_base extends question_edit_form {
      * definition_inner adds all specific fields to the form.
      * @param object $mform (the form being built).
      */
-    function definition_inner($mform) {
+    protected function definition_inner($mform) {
         global $CFG;
 
         //add the answer (choice) fields to the form
@@ -242,7 +242,7 @@ class qtype_gapselect_edit_form_base extends question_edit_form {
         return false;
     }
 
-    function qtype() {
+    public function qtype() {
         return '';
     }
 }
\ No newline at end of file

question/type/gapselect/edit_gapselect_form.php

@@ -40,7 +40,7 @@ class qtype_gapselect_edit_form extends qtype_gapselect_edit_form_base {
     // HTML tags allowed in answers (choices).
     protected $allowedhtmltags = array();
 
-    function qtype() {
+    public function qtype() {
         return 'gapselect';
     }
 }

question/type/gapselect/questiontype.php

@@ -57,7 +57,7 @@ class qtype_gapselect extends qtype_gapselect_base {
         return 'selectgroup';
     }
 
-    function import_from_xml($data, $question, $format, $extra=null) {
+    public function import_from_xml($data, $question, $format, $extra=null) {
         if (!isset($data['@']['type']) || $data['@']['type'] != 'gapselect') {
             return false;
         }
@@ -98,7 +98,7 @@ class qtype_gapselect extends qtype_gapselect_base {
         return $question;
     }
 
-    function export_to_xml($question, $format, $extra = null) {
+    public function export_to_xml($question, $format, $extra = null) {
         $output = '';
 
         $output .= '    <shuffleanswers>' . $question->options->shuffleanswers . "</shuffleanswers>\n";

question/type/gapselect/questiontypebase.php

@@ -308,7 +308,7 @@ abstract class qtype_gapselect_base extends question_type {
         return $parts;
     }
 
-    function move_files($questionid, $oldcontextid, $newcontextid) {
+    public function move_files($questionid, $oldcontextid, $newcontextid) {
         parent::move_files($questionid, $oldcontextid, $newcontextid);
 
         $fs = get_file_storage();