Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE

David Monllaó authored Nov 11, 2015 and Dan Poltawski committed Nov 11, 2015

Merge branch 'MDL-51913_statistics_dup_1st_column_MDL28' of git://github.com/barrysspace/moodle into MOODLE_28_STABLE

If a user does not have the 'moodle/calendar:manageentries' capability then an E_WARNING
can be generated by the core_calendar_external::get_calendar_events() method, that an
expected array is null

This patch creates an array that is missing when a user does not have the capability.

If is user requests a single event on a course via the web service they should be able to retrieve it.

Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE

The default behaviour of $OUTPUT->notification() is to indiciate a
problem.

(Previous approach of making up ids longer works now we are validating
them..)

This unit test does not verify contents, details, but only
that the returned users for every group mode, for every
filtering (active, groupid and withcapability) together
with permissions are correct.

These unit tests were modifying the PAGE and other globals in the middle of
tests and were failing as a result.

Broke the tests up into separate tests where the functionality is now
tested individually.

Damyon Wiese authored Nov 05, 2015 and Dan Poltawski committed Nov 05, 2015

Make sure any submitted choice options actually belong to the current choice
module.

Even when the table has no userid column (this is normally the edit column).