1. 14 Apr, 2016 2 commits
    • Damyon Wiese's avatar
      MDL-53772 libraries: More context fixes · e02e7f5a
      Damyon Wiese authored and David Monllaó's avatar David Monllaó committed
      1. Improve upgrade note
      2. Don't abuse $PAGE to get the current course/cm
      3. Use validate_context, never $PAGE->set_context()
      4. Reset current coursemodule in validate_context().
      5. Respect moodlepageclass when calling an external function.
      e02e7f5a
    • Damyon Wiese's avatar
      MDL-53772 externallib: Fix busted webservices context handling · 56fa860e
      Damyon Wiese authored
      Fix:
      $PAGE->context must be reset when calling validate_context
      
      Improve:
      Provide wrapper for calling an external function
      
      The wrapper correctly checks the function parameters and return type against
      the description of the external function, and stores the PAGE and COURSE global
      state variables, restoring them before the function returns.
      
      Fix: buggy unit tests.
      
      These tests are expecting debugging from a bug that was fixed, and calling web
      service functions with no user or session.
      56fa860e
  2. 08 Apr, 2016 1 commit
  3. 06 Apr, 2016 1 commit
  4. 05 Apr, 2016 2 commits
  5. 01 Apr, 2016 2 commits
  6. 30 Mar, 2016 2 commits
  7. 22 Mar, 2016 1 commit
  8. 21 Mar, 2016 1 commit
  9. 16 Mar, 2016 1 commit
  10. 11 Mar, 2016 1 commit
    • Alexandru Elisei's avatar
      MDL-52574 accesslib: Prevent get_role_users() fail in certain cases · b6d12864
      Alexandru Elisei authored
      The function get_role_users() requires the caller to include the $sort fields in
      the $fields argument. On PostgreSQL this will cause the function to fail when
      the default $sort fields aren't part of the requested fields. The behavior of
      the function is augmented to add the $sort fields to $fields if they are not
      already present.
      b6d12864
  11. 10 Mar, 2016 1 commit
  12. 09 Mar, 2016 2 commits
    • Andrew Nicols's avatar
      MDL-53273 search: Whitespace fix · d84a657d
      Andrew Nicols authored
      d84a657d
    • Damyon Wiese's avatar
      MDL-51324 forms: Add a new course selector · 235ef57a
      Damyon Wiese authored
      This is a squashed commit containing a number of changes:
      
      This is an ajax driven course selector that has searching etc. It can select single, or multiple courses.
      Make course selector accept a list of courses to exclude
      courseselector - lookup coursename on setValue
      Use the get_course_display_name_in_list function to generate the course names
      Add a throttle to auto-complete to reduce spamming the server
      Do a single query to fetch all the courses in the mform element when validation fails
      Fix core course search function to return results when there are less than 2 chars in the query.
      Handle setData with an empty array in new course selector
      235ef57a
  13. 07 Mar, 2016 1 commit
  14. 29 Feb, 2016 2 commits
  15. 28 Feb, 2016 1 commit
  16. 25 Feb, 2016 1 commit
  17. 16 Feb, 2016 1 commit
    • Eloy Lafuente's avatar
      MDL-51580 upgradelib: Delete stuff used by removed upgrade steps · 1405f010
      Eloy Lafuente authored
      This commits removes stuff from different upgradelib files, used
      exclusively by the already deleted upgrade steps. Given such
      exclusivity it was not needed to proceed with a 2-phase deprecation
      as far as the functions were 100% internal to upgrade.
      
      This is the list of deleted functions, all them docummented in their
      corresponding upgrade.txt files:
      
      - repository_picasa_admin_upgrade_notification();
      - repository_googledocs_admin_upgrade_notification();
      - repository_boxnet_admin_upgrade_notification();
      - repository_alfresco_admin_security_key_notice();
      - qtype_essay_convert_to_html();
      - portfolio_picasa_admin_upgrade_notification();
      - portfolio_googledocs_admin_upgrade_notification();
      - portfolio_boxnet_admin_upgrade_notification();
      - mod_book_migrate_moddata_dir_to_legacy();
      - mod_book_migrate_all_areas();
      - mod_book_migrate_area();
      - mod_assignment_pending_upgrades_notification();
      - upgrade_mysql_fix_unsigned_and_lob_columns();
      - upgrade_course_completion_remove_duplicates();
      - upgrade_save_orphaned_questions();
      - upgrade_rename_old_backup_files_using_shortname();
      - upgrade_mssql_nvarcharmax();
      - upgrade_mssql_varbinarymax();
      - upgrade_fix_missing_root_folders();
      - upgrade_course_modules_sequences();
      - upgrade_grade_item_fix_sortorder();
      - upgrade_availability_item();
      1405f010
  18. 11 Feb, 2016 1 commit
  19. 22 Jan, 2016 1 commit
  20. 19 Jan, 2016 1 commit
  21. 10 Jan, 2016 1 commit
  22. 30 Dec, 2015 1 commit
  23. 14 Dec, 2015 1 commit
  24. 11 Dec, 2015 1 commit
  25. 10 Dec, 2015 1 commit
  26. 02 Dec, 2015 1 commit
  27. 01 Dec, 2015 1 commit
  28. 24 Nov, 2015 1 commit
  29. 23 Nov, 2015 1 commit
    • David Mudrák's avatar
      MDL-52214 core: Fix the is_web_crawler() regression · 182d9990
      David Mudrák authored
      In MDL-50891, the is_web_crawler() was refactored into a core_useragent
      method and the function itself was deprecated. However, there were no
      unit tests kept to check the backwards compatible behaviour. It turned
      out that the deprecated function leads to PHP fatal error due to a typo.
      
      This patch fixes the typo and brings back the previous unit tests. To be
      able to explicitly check the raised debugging message, the test case
      now must be subclass of advanced_testcase.
      
      Additionally fixes missing info about the function being deprecated.
      182d9990
  30. 12 Oct, 2015 1 commit
    • Andrew Nicols's avatar
      MDL-51524 libraries: Update to latest version of html2text · ec2d33df
      Andrew Nicols authored
      We were previously using an ancient version of html2text from RoundCube
      with many customisations.
      
      This patchset moves to the version included in the latest version of
      HTML2Text, and wraps the library in a moodle-provided class. This
      moves all previous hacks away from that class.
      
      Unfortunately, two hacks still remain - two of the functions in the
      RoundCube class are private, and must be modified to protected in order to
      use the class effectively.
      ec2d33df
  31. 06 Oct, 2015 1 commit
  32. 05 Oct, 2015 1 commit
  33. 02 Oct, 2015 1 commit
  34. 30 Sep, 2015 1 commit