Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE

The default behaviour of $OUTPUT->notification() is to indiciate a
problem.

(Previous approach of making up ids longer works now we are validating
them..)

This unit test does not verify contents, details, but only
that the returned users for every group mode, for every
filtering (active, groupid and withcapability) together
with permissions are correct.

These unit tests were modifying the PAGE and other globals in the middle of
tests and were failing as a result.

Broke the tests up into separate tests where the functionality is now
tested individually.

Damyon Wiese authored Nov 05, 2015 and Dan Poltawski committed Nov 05, 2015

Make sure any submitted choice options actually belong to the current choice
module.

Even when the table has no userid column (this is normally the edit column).

This patch adds a method to the course completion criteria classes
which allows them to specify an icon for display in the course
completion report table.

There is a default implementation which simply looks for an icon
in pix/i with a name matching the completion criteria type.

The function unformat_float can return 0 and false.
We need to do strict comparison for the return value on line 92 to accept grades 0.00.

David Monllaó authored Oct 22, 2015 and Dan Poltawski committed Nov 04, 2015

Credit to Yuliya Bozhko.