The navigation block is visible in clean so "I should not see courses" finds the link in the navigation block

David Herney authored Nov 27, 2017 and jun committed Dec 06, 2017

The variable $type really is $dataformat. I have changed it for
prevent the error and show a correct error message.

Damyon Wiese authored Dec 05, 2017 and jun committed Dec 06, 2017

When fields are disabled, the value comes through as null so we need to specifically check for it
before validation.

Redis unit tests are currently failing on php 7.2 due to https://bugs.php.net/bug.php?id=75628

Adds back-end support for restricting searches to specified context
ids (for example so it is possible to search only a specific forum).

Only course tools are backed up, site tools and registrations
can be matched by id if they are restored to the same site only.

For predefined course tools the secret is backed up encrypted
and can be restored on the same site only.

All these functions were used only by deleted upgrade steps
so it's safe to proceed with straight deletion, considering
them internal. Deletion has been documented in corresponding
upgrade.txt files:

- mod_feedback_upgrade_delete_duplicate_values()
- mod_feedback_upgrade_courseid()

These have been kept because they continue being used:

- @ install: make_competence_scale()
- @ restore: upgrade_course_letter_boundary()

LTS (3.5) requires previous LTS (3.1)

This just deletes all the upgrade steps previous to 3.1.0. Some
small adjustments, like adding missing MOODLE_INTERNAL or tweaking
globals can also be applied when needed.

Also includes an upgrade step to prevent upgrading from any
version < 2016052300 (v3.1.0) as anti-cheating measure.

Next commit will get rid of/deprecate all the upgradelib functions
not used anymore in codebase.

This is a direct copy of the 3.4 branch to
have changes under control easier in next commits.