Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
prechecker
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Analytics
Analytics
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
integration
prechecker
Commits
9244faa3
Commit
9244faa3
authored
Dec 12, 2017
by
jun
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'MDL-59766-master' of
git://github.com/damyon/moodle
parents
6b58bb56
9a73d11c
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
11 additions
and
5 deletions
+11
-5
mod/assign/feedback/editpdf/lang/en/assignfeedback_editpdf.php
...ssign/feedback/editpdf/lang/en/assignfeedback_editpdf.php
+2
-0
mod/assign/feedback/editpdf/locallib.php
mod/assign/feedback/editpdf/locallib.php
+4
-5
mod/assign/feedback/editpdf/settings.php
mod/assign/feedback/editpdf/settings.php
+5
-0
No files found.
mod/assign/feedback/editpdf/lang/en/assignfeedback_editpdf.php
View file @
9244faa3
...
...
@@ -39,6 +39,8 @@ $string['command'] = 'Command:';
$string
[
'commentcontextmenu'
]
=
'Comment context menu'
;
$string
[
'couldnotsavepage'
]
=
'Could not save page {$a}'
;
$string
[
'currentstamp'
]
=
'Stamp'
;
$string
[
'default'
]
=
'Enabled by default'
;
$string
[
'default_help'
]
=
'If set, this feedback method will be enabled by default for all new assignments.'
;
$string
[
'deleteannotation'
]
=
'Delete annotation'
;
$string
[
'deletecomment'
]
=
'Delete comment'
;
$string
[
'deletefeedback'
]
=
'Delete feedback PDF'
;
...
...
mod/assign/feedback/editpdf/locallib.php
View file @
9244faa3
...
...
@@ -332,12 +332,11 @@ class assign_feedback_editpdf extends assign_feedback_plugin {
}
/**
* Automatically enable or disable editpdf feedback plugin based on
* whether the ghostscript path is set correctly.
* Determine if ghostscript is available and working.
*
* @return bool
*/
public
function
is_
enabled
()
{
public
function
is_
available
()
{
if
(
$this
->
enabledcache
===
null
)
{
$testpath
=
assignfeedback_editpdf\pdf
::
test_gs_path
(
false
);
$this
->
enabledcache
=
(
$testpath
->
status
==
assignfeedback_editpdf\pdf
::
GSPATH_OK
);
...
...
@@ -345,12 +344,12 @@ class assign_feedback_editpdf extends assign_feedback_plugin {
return
$this
->
enabledcache
;
}
/**
*
Automatically hide the setting for the editpdf feedback plugin
.
*
Prevent enabling this plugin if ghostscript is not available
.
*
* @return bool false
*/
public
function
is_configurable
()
{
return
false
;
return
$this
->
is_available
()
;
}
/**
...
...
mod/assign/feedback/editpdf/settings.php
View file @
9244faa3
...
...
@@ -24,6 +24,11 @@
defined
(
'MOODLE_INTERNAL'
)
||
die
();
// Enabled by default.
$settings
->
add
(
new
admin_setting_configcheckbox
(
'assignfeedback_editpdf/default'
,
new
lang_string
(
'default'
,
'assignfeedback_editpdf'
),
new
lang_string
(
'default_help'
,
'assignfeedback_editpdf'
),
1
));
// Stamp files setting.
$name
=
'assignfeedback_editpdf/stamps'
;
$title
=
get_string
(
'stamps'
,
'assignfeedback_editpdf'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment