Commit 50302c40 authored by Damyon Wiese's avatar Damyon Wiese
Browse files

MDL-56790 boost: Styling fixes for mod_feedback

Also fixed are problems with frozen select from elements showing raw
HTML. I checked the other form templates for similar problems and fixed
them all.
parent 235a80b2
......@@ -124,10 +124,6 @@ class feedback_edit_create_template_form extends moodleform {
get_string('public', 'feedback'));
}
// buttons
$elementgroup[] = $mform->createElement('submit',
'create_template',
get_string('save_as_new_template', 'feedback'));
$mform->addGroup($elementgroup,
'elementgroup',
......@@ -135,6 +131,9 @@ class feedback_edit_create_template_form extends moodleform {
array(' '),
false);
// Buttons.
$mform->addElement('submit', 'create_template', get_string('save_as_new_template', 'feedback'));
$mform->setType('templatename', PARAM_TEXT);
$this->set_data(array('id' => $this->_customdata['id']));
......
......@@ -9,6 +9,9 @@ select {
width: auto;
}
.path-mod-feedback .feedback_form .col-form-label {
display: block !important; /* stylelint-disable-line declaration-no-important */
}
// Feedback module
.path-mod-feedback .itemactions {
float: right;
......
......@@ -9,14 +9,14 @@
{{/error}}
{{{element.attributes}}} >
{{#element.options}}
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{text}}</option>
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{{text}}}</option>
{{/element.options}}
</select>
{{/element.frozen}}
{{#element.frozen}}
{{#element.options}}
{{#selected}}
{{text}}
{{{text}}}
{{^element.hardfrozen}}
<input type="hidden" name="{{element.name}}" value="{{value}}">
{{/element.hardfrozen}}
......
......@@ -12,14 +12,14 @@
{{/error}}
{{{element.attributes}}} >
{{#element.options}}
<option value="{{value}}" {{#selected}}selected{{/selected}} {{#disabled}}disabled{{/disabled}} {{{optionattributes}}}>{{text}}</option>
<option value="{{value}}" {{#selected}}selected{{/selected}} {{#disabled}}disabled{{/disabled}} {{{optionattributes}}}>{{{text}}}</option>
{{/element.options}}
</select>
{{/element.frozen}}
{{#element.frozen}}
{{#element.options}}
{{#selected}}
{{text}}
{{{text}}}
{{^element.hardfrozen}}
<input type="hidden" name="{{element.name}}" value="{{value}}" id="{{element.id}}">
{{/element.hardfrozen}}
......
......@@ -19,7 +19,7 @@
{{#element.frozen}}
{{#element.options}}
{{#selected}}
{{text}}
{{{text}}}
{{^element.hardfrozen}}
<input type="hidden" name="{{element.name}}" value="{{value}}" id="{{element.id}}">
{{/element.hardfrozen}}
......
......@@ -9,13 +9,13 @@
{{/error}}
{{{element.attributes}}} >
{{#element.options}}
<option value="{{value}}" {{#selected}}selected{{/selected}} {{#disabled}}disabled{{/disabled}} {{{optionattributes}}}>{{text}}</option>
<option value="{{value}}" {{#selected}}selected{{/selected}} {{#disabled}}disabled{{/disabled}} {{{optionattributes}}}>{{{text}}}</option>
{{/element.options}}
</select>
{{/element.frozen}}
{{#element.frozen}}
{{#element.options}}
{{#selected}}{{text}}{{/selected}}
{{#selected}}{{{text}}}{{/selected}}
{{/element.options}}
{{/element.frozen}}
<a class="m-x-1" href="{{{element.link}}}">{{element.linklabel}}</a>
......
......@@ -9,13 +9,13 @@
{{/error}}
{{{element.attributes}}} >
{{#element.options}}
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{text}}</option>
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{{text}}}</option>
{{/element.options}}
</select>
{{/element.frozen}}
{{#element.frozen}}
{{#element.options}}
{{#selected}}{{text}}{{/selected}}
{{#selected}}{{{text}}}{{/selected}}
{{/element.options}}
{{/element.frozen}}
{{#element.managestandardtagsurl}}
......
......@@ -9,13 +9,13 @@
{{/error}}
{{{element.attributes}}} >
{{#element.options}}
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{text}}</option>
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{{text}}}</option>
{{/element.options}}
</select>
{{/element.frozen}}
{{#element.frozen}}
{{#element.options}}
{{#selected}}{{text}}{{/selected}}
{{#selected}}{{{text}}}{{/selected}}
{{/element.options}}
{{/element.frozen}}
{{#element.managestandardtagsurl}}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment