Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
integration
prechecker
Commits
0f989a4c
Commit
0f989a4c
authored
Jan 27, 2016
by
Juan Leyva
Committed by
Eloy Lafuente
Mar 08, 2016
Browse files
MDL-52901 mod_assign: Check due dates in external save_submission
parent
b74d0f84
Changes
2
Hide whitespace changes
Inline
Side-by-side
mod/assign/externallib.php
View file @
0f989a4c
...
...
@@ -1636,9 +1636,12 @@ class mod_assign_external extends external_api {
$notices
=
array
();
$submissiondata
=
(
object
)
$params
[
'plugindata'
];
$assignment
->
save_submission
(
$submissiondata
,
$notices
);
if
(
!
$assignment
->
submissions_open
(
$USER
->
id
))
{
$notices
[]
=
get_string
(
'duedatereached'
,
'assign'
);
}
else
{
$submissiondata
=
(
object
)
$params
[
'plugindata'
];
$assignment
->
save_submission
(
$submissiondata
,
$notices
);
}
$warnings
=
array
();
foreach
(
$notices
as
$notice
)
{
...
...
mod/assign/tests/externallib_test.php
View file @
0f989a4c
...
...
@@ -928,6 +928,16 @@ class mod_assign_external_testcase extends externallib_advanced_testcase {
$this
->
assertEquals
(
0
,
count
(
$result
));
// Set up a due and cutoff passed date.
$instance
->
duedate
=
time
()
-
WEEKSECS
;
$instance
->
cutoffdate
=
time
()
-
WEEKSECS
;
$DB
->
update_record
(
'assign'
,
$instance
);
$result
=
mod_assign_external
::
save_submission
(
$instance
->
id
,
$submissionpluginparams
);
$result
=
external_api
::
clean_returnvalue
(
mod_assign_external
::
save_submission_returns
(),
$result
);
$this
->
assertCount
(
1
,
$result
);
$this
->
assertEquals
(
get_string
(
'duedatereached'
,
'assign'
),
$result
[
0
][
'item'
]);
}
/**
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment